fix(clap_complete_nushell): correctly handle commands whose short description is more than one line #5359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
poliorcetics
force-pushed
the
ab/push-szymvyzpmnqx
branch
from
f80166c to
db4d909
Compare
Found while trying to add Nushell completions to [`jj`](https://github.com/martinvonz/jj).
epage
force-pushed
the
ab/push-szymvyzpmnqx
branch
from
db4d909 to
d285267
Compare
While I've not always been good about this, I do try to keep the completions in line with each other. As for StyledStr, that is too low level to care about policy like this. |
epage
force-pushed
the
ab/push-szymvyzpmnqx
branch
from
d285267 to
e782775
Compare
|
Thanks for the amazingly quick review! When you have time, could you make a release with the fix ? |
|
4.5.1 should already be out with the fix |
|
Ah, I missed it, thanks a lot ! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while trying to add Nushell completions to
jj.Questions
I implemented it in
clap_complete_nushellfor now, but I could see it being useful in other shells, maybe it should be handled byStyledStrdirectly ?